docs(lua transform): Add a guide about merging multi-line events #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
ghost
requested a review
from Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
binarylogic
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
I don't have any constructive feedback, this is a really nice guide and I'm happy we have it.
It avoids issues like fluent/fluent-bit#337.
| In the end, when the state holds enough data to extract all fields, a merged event is emitted and | ||
| the state is emptied. Then the process repeats as new events arrive. | ||
|
|
||
| ## Safety Checks |
There was a problem hiding this comment.
I really like this section. Nice work! This is where similar Lua scripts fall short.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2306.
Ref fluent/fluent-bit#337.