chore: Tidy up disused commented code #8580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does not functionally change VRL but does remove a block of commented out test code. The code does not have a link to an issue describing what should be done to re-enable it and it has sat like this for some months. Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
|
✔️ Deploy Preview for vector-project ready! 🔨 Explore the source changes: 11e7016 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/61098fd3e5d0d3000713211c 😎 Browse the preview: https://deploy-preview-8580--vector-project.netlify.app |
spencergilbert
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
I'm fine removing them, but might be good to get @JeanMertz or @StephenWakely to take a look and see if they know why
lukesteensen
approved these changes
Aug 3, 2021
dbcfd
pushed a commit
to dbcfd/vector
that referenced
this pull request
Aug 18, 2021
This commit does not functionally change VRL but does remove a block of commented out test code. The code does not have a link to an issue describing what should be done to re-enable it and it has sat like this for some months. Signed-off-by: Brian L. Troutwine <brian@troutwine.us> Signed-off-by: dbcfd <bdbrowning2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does not functionally change VRL but does remove a block of
commented out test code. The code does not have a link to an issue describing
what should be done to re-enable it and it has sat like this for some months.
Signed-off-by: Brian L. Troutwine brian@troutwine.us