Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vrl): Remove skipped coalesce test as it's duplicated by unnecessary_error_coalesce.vrl #8754

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

spencergilbert
Copy link
Contributor

Signed-off-by: Spencer Gilbert spencer.gilbert@datadoghq.com

Was unsure if we needed to move the issue to the tests/issues directory since the test was actually already present.

Duplicating test introduced: #6471

…lesce.vrl

Signed-off-by: Spencer Gilbert <spencer.gilbert@datadoghq.com>
@spencergilbert spencergilbert added the domain: vrl Anything related to the Vector Remap Language label Aug 16, 2021
@spencergilbert spencergilbert self-assigned this Aug 16, 2021
@netlify
Copy link

netlify bot commented Aug 16, 2021

✔️ Deploy Preview for vector-project ready!

🔨 Explore the source changes: 12380e2

🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/611ae859a3cfba00078cc77c

😎 Browse the preview: https://deploy-preview-8754--vector-project.netlify.app

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for the clean-up

@spencergilbert
Copy link
Contributor Author

👍 thanks for the clean-up

NP, got curious why it was skipped when I was testing my rebuilt build server. I'll let one of Jean or Stephen decide on the delete vs move

Copy link
Contributor

@StephenWakely StephenWakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@StephenWakely
Copy link
Contributor

I'll let one of Jean or Stephen decide on the delete vs move

As you point out it's duplicated in another test, so there's no point keeping this around.

@spencergilbert spencergilbert merged commit e876d40 into master Aug 18, 2021
@spencergilbert spencergilbert deleted the remove-skipped-vrl-test branch August 18, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: vrl Anything related to the Vector Remap Language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants