chore: Migrate API_KEY_MATCHER and log_schema() into DatadogAgentSource #8789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes a lazy_static and call to a lazy_static from the DatadogAgentSource. As a part of #8512 I spent some time trying to remove warp from the agent source to see its effect and found that, on the whole, it would not really be worth all that much. warp might bloat our stack traces somewhat but is lean internally. That said, I did find that I could remove some serialization from the source, primarily by migrating globally retrieved types into the source struct itself. See also #8472 Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
|
✔️ Deploy Preview for vector-project canceled. 🔨 Explore the source changes: 54389e6 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/611e954d3595030007bf3e78 |
blt
changed the title
spencergilbert
approved these changes
Aug 19, 2021
jszwedko
approved these changes
Aug 19, 2021
Signed-off-by: Brian L. Troutwine <brian@troutwine.us> Co-authored-by: Jesse Szwedko <jesse@szwedko.me>
Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes a lazy_static and call to a lazy_static from the
DatadogAgentSource. As a part of #8512 I spent some time trying to remove warp
from the agent source to see its effect and found that, on the whole, it would
not really be worth all that much. warp might bloat our stack traces somewhat
but is lean internally. That said, I did find that I could remove some
serialization from the source, primarily by migrating globally retrieved types
into the source struct itself.
See also #8472
Signed-off-by: Brian L. Troutwine brian@troutwine.us