chore: Speed up LogEvent::rename_key by 57%
#9226
Conversation
This commit speeds up the `rename_key` function of `LogEvent` by 57%, avoiding the use of path iteration code to achieve this. This results in +2MB/s in #8512. Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
|
✔️ Deploy Preview for vector-project ready! 🔨 Explore the source changes: 42bb5ce 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/6145383a060640000764f3c2 😎 Browse the preview: https://deploy-preview-9226--vector-project.netlify.app |
| @@ -137,12 +137,17 @@ impl LogEvent { | |||
| K: AsRef<str> + Into<String> + PartialEq + Display, | |||
| { | |||
| if from_key != to_key { | |||
| if let Some(val) = self.remove(from_key) { | |||
| if let Some(val) = self.fields.as_map_mut().remove(from_key.as_ref()) { | |||
There was a problem hiding this comment.
Should we update the tests below to catch this in the future? Presumably self.remove() was not right since it would have interpreted the key as a path.
There was a problem hiding this comment.
In the long-term I'd prefer to see the _flat functions disappear. Right now we avoid them to get a performance boost while the two lookup situations are in play. I do see your point about checking that we don't interpret the path, though. I'd like to gate that work on #9131 since it'll be a natural consequence of doing that work well.
This commit speeds up the
rename_keyfunction ofLogEventby 57%, avoidingthe use of path iteration code to achieve this. This results in +2MB/s in #8512.
Signed-off-by: Brian L. Troutwine brian@troutwine.us