enhancement(file sink): Add support for end-to-end acknowledgements #9892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
bruceg
added
type: enhancement
|
✔️ Deploy Preview for vector-project canceled. 🔨 Explore the source changes: 183362d 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/618409de2be9a700075a3e18 |
tobz
approved these changes
Nov 4, 2021
Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
|
I'm curious if this needs docs changes? Can't acknowledgements be enabled/disabled via config? |
Acknowledgements are either supported or not on sinks, as it is just a matter of reporting delivery. The only way we could "disable" acknowledgements on sinks would be to report delivered as soon as they enter the sink, which doesn't make a lot of sense IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty trivial, but there's not much that actually needs to be done for this one. The biggest thing missing is tests, and the errors definitely don't meet the component spec (would require a fuller audit).
Closes #7664
Signed-off-by: Bruce Guenter bruce.guenter@datadoghq.com