Fix the API bug that cause Outlook plugin fail to sync #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
PHP die and the API returns nothing. This cause the sync on Outlook failed.
When syncing in Outlook, some custom fields will clash the process.
After
Corrects the function call, so the API will return the result.
Adds prefix to the name of custom fields in the return values to prevent name clash.
Note
Change the pattern of the result into the format of Civi APIv3. This change doesn't affect the Outlook plugin.
Agileware ref: CIVIOLK-1