Use mkstemp instead of tempnam
#235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywwry66
force-pushed
the
remove-tempnam
branch
2 times, most recently
from
87f36cc
to
e7157a8
Compare
Difference from 37bbe86: Set temporary directory path in runtime using environment variable: "TMP" for Windows and "TMPDIR" for Unix-like. This is because "P_tmpdir" does not expand correctly on Windows. If the environment variable is not set, falls back to "P_tmpdir". Temp filename examples: - Windows 11: C:\Users\<username>\AppData\Local\Temp\epdfinfo_xxxxxx - MSYS2 on Windows 11: <path_to_msys2>\tmp\epdfinfo_xxxxxx - macOS Ventura:/var/folders/xx/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/T/epdfinfo_xxxxxx Closes vedang#110
ywwry66
force-pushed
the
remove-tempnam
branch
from
e7157a8
to
b194109
Compare
|
CI failure is unrelated. |
|
Thank you, I have been waiting for someone to fix this on Windows correctly. I will review and merge it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Difference from 37bbe86: Set temporary directory path in runtime using environment variable: "TMP" for Windows and "TMPDIR" for Unix-like. This is because "P_tmpdir" does not expand correctly on Windows. If the environment variable is not set, falls back to "P_tmpdir".
Temp filename examples:
Closes #110