refactor: Improvement in CycleSort algorithm (iluwatar#195)

Fixes iluwatar#194
vedantzope9 · Oct 14, 2023 · 5123af2 · 5123af2
1 parent d4fefde
commit 5123af2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -174,7 +174,7 @@ Inspired by [30 seconds of code](https://github.com/Chalarangelo/30-seconds-of-c
     int i = 0;
     while (i < n) {
       int correctpos = arr[i] - 1;
-      if (arr[i] < n && arr[i] != arr[correctpos]) {
+      if (arr[i] != arr[correctpos]) {
         int temp = arr[i];
         arr[i] = arr[correctpos];
         arr[correctpos] = temp;

diff --git a/src/main/java/algorithm/CycleSortSnippet.java b/src/main/java/algorithm/CycleSortSnippet.java
@@ -40,7 +40,7 @@ public static int[] cycleSort(int[] arr) {
     int i = 0;
     while (i < n) {
       int correctpos = arr[i] - 1;
-      if (arr[i] < n && arr[i] != arr[correctpos]) {
+      if (arr[i] != arr[correctpos]) {
         int temp = arr[i];
         arr[i] = arr[correctpos];
         arr[correctpos] = temp;