Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for ColReorder to remaining filter_types #138

Closed
luivis07 opened this issue Jan 7, 2015 · 4 comments
Closed

Adding support for ColReorder to remaining filter_types #138

luivis07 opened this issue Jan 7, 2015 · 4 comments

Comments

@luivis07
Copy link

luivis07 commented Jan 7, 2015

This is related to this issue: #107.
Would like to add the 'multi_select' filter type and the 'range_number_slider' to have the same fix as the 'select' and 'text' filters.

@luivis07
Copy link
Author

It seems like these filter types already support ColReorder since they have the column number as one of their parameters in the function.

@vedmack
Copy link
Owner

vedmack commented Jan 13, 2015

they do have the original column number, but when doing the col re order yadcf needs to find the new column number (the index after re order) and that is implemented only for select/text atm

@vedmack vedmack reopened this Jan 13, 2015
@luivis07
Copy link
Author

ok I'll leave this one open then.

@vedmack
Copy link
Owner

vedmack commented Mar 8, 2015

Added to all the remaining filter types,grab the latest beta 0.8.8.beta.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants