Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being able to use smart filtering in case of contains filter_match_mode #148

Closed
MrCsabaToth opened this issue Jan 19, 2015 · 3 comments
Closed

Comments

@MrCsabaToth
Copy link
Contributor

I'm in the situation when the users have the global search box and yadcf text filters per column too. They expect the same kind of functionality from both: if they type fraction of keywords after each other separated by space, the search engine would basically split the whole term to multiple terms separated by space and evaluate each. That's what smart search (bSmart) does under the hood.

https://stackoverflow.com/questions/27997189/yadcf-smart-filtering-with-contains-filter

So far I made a modification in yadcfMatchFilter:

if (filter_match_mode === "contains") {
            oTable.fnFilter(selected_value, column_number, false, true, true, case_insensitive);

Notice that the parameters are not false false true, but false true true, the second parameters is the bSmart for fnFilter.

@MrCsabaToth
Copy link
Contributor Author

I think this could be some kind of configuration option

@vedmack
Copy link
Owner

vedmack commented Jan 20, 2015

Will check this one later on, but I actually think that for contains it would be better set the bSmart into true (permanently)

vedmack added a commit that referenced this issue Jan 29, 2015
auto_complete filter can accept an object to use it later in its constructor (for examplefor external ajax source)

#148
#144
@vedmack
Copy link
Owner

vedmack commented Jan 29, 2015

bSmart is set to true in contains (0.8.7.beta.12)

@vedmack vedmack closed this as completed Jan 29, 2015
vedmack added a commit that referenced this issue Jan 30, 2015
auto_complete filter can accept an object to use it later in its constructor (for examplefor external ajax source)

#148
#144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants