Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jquery plugins memory leak #213

Closed
gauravjhs opened this issue Jun 19, 2015 · 5 comments
Closed

Jquery plugins memory leak #213

gauravjhs opened this issue Jun 19, 2015 · 5 comments

Comments

@gauravjhs
Copy link
Contributor

When destroying datatables and yadcf instance, other plugins for number slider and select plugin are not destroyed which leads to memory leak.
@gauravjhs
Copy link
Contributor Author

Hi Daniel. Any view on this? I can help on this if we can discuss how to go forward with this.

@vedmack
Copy link
Owner

vedmack commented Sep 24, 2015

Hi,

Sorry . lack of time recently, the solution should be very simple, inside the removeFilters function you should call a helper function that will iterate over all yadcf options and with a simple switch will call the destory function of the third party plugin (if used for that column). PR is welcome

@vedmack
Copy link
Owner

vedmack commented Sep 26, 2015

gonna release this enachcement soon

vedmack added a commit that referenced this issue Sep 26, 2015
@vedmack
Destroy third party plugins on datatable destroy
5513793 
#213
@vedmack
Copy link
Owner

vedmack commented Sep 26, 2015

fixed that one in 0.8.9.beta.19, please confirm its working well

@vedmack vedmack closed this as completed Sep 26, 2015
@gauravjhs
Copy link
Contributor Author

This is great. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vedmack @gauravjhs