Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear not used / inuse class not removed when custom_func 'Select Value' (remove filter) selected #279

Closed
xmikew opened this issue Jan 18, 2016 · 2 comments
Labels

Comments

@xmikew
Copy link

xmikew commented Jan 18, 2016

https://jsfiddle.net/t372e7rh/1/ (column 2 is our column of interest)

using a custom_func with data parameter. I noticed that on 0.8.8 when selecting the "Select Value" option did nothing. In 0.8.9b, the values are reset, but the 'inuse' class is never removed. I set a breakpoint on:

In doFilterCustomDateFunc (starting around line 745)

        if (arg === "clear") {
            if (exGetColumnFilterVal(oTable, column_number) === '') {
                return;
            }
            $("#yadcf-filter-" + table_selector_jq_friendly + "-" + column_number).val('-1').focus();
            $("#yadcf-filter-" + table_selector_jq_friendly + "-" + column_number).removeClass("inuse");

However, the arg is never set to 'clear' -- perhaps this is expected when i do not use a filter_reset_button (set _text to false).

However, inuse class is never removed. when selecting "Select Value" -- I'll dig into a little more tonight but perhaps it would be easier for you to find.

Thanks as always.

- Mike

@xmikew
Copy link
Author

xmikew commented Jan 19, 2016

using fixed version: https://jsfiddle.net/t372e7rh/2

vedmack added a commit that referenced this issue Jan 23, 2016
Fix issue #279 - clear css class on select when using custom_func.

Its almost complete, will commit a fix to it in a few
@vedmack
Copy link
Owner

vedmack commented Jan 23, 2016

Final fix in 0.8.9.beta.38

Thanks for your PR

@vedmack vedmack closed this as completed Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants