fix: emissions calculation given a maximum emissions and deadline #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to add this somewhere that end users can verify this is correct. Need to also provably verify who is on the multisig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So given that we have a maximum amount of emissions that a receiver can get + a deadline, I handled it by just setting
week_time = deadlinein the case that the deadline is between the two time periods we are calculating emissions for.This should be adjusted to look prettier, feels like there is duplication and the logic can be simplified.
There was an alternative way to do this as well, where we have an internal
_checkpointfunction that we pass parameters to, but this way seems better since it's self contained in a single function.