Important bug fix for ambigous character resolutions #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for Reagan Kelly of the CDC for tracking down this issue.
Starting in version 1.0.8 there was a subtle bug that would manifest if the first ambiguous character in the first sequence being compared fell on an odd (0-based position) in the first half (roughly) of the sequence. This would cause the code to incorrectly skip the pair of nucleotides with the ambiguous base and instead double-count the next pair of characters, so in something like
So for example
would return
0
for the distance betweenSeq1
andSeq2
, because instead of comparing theR-A
pair, the code would instead compareC-C
(the next position)