-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve encoding section #2735
Merged
Merged
Improve encoding section #2735
Changes from 17 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
c1a2ae9
Remove key channel as not relevant for Altair and not documented anyway
binste f391466
Add explanation and description to detail channel
binste 80fe108
Add explanation on difference between datum and value
binste 93f09f5
Remove key and description also from channel option sections
binste a272039
Update doc/user_guide/encoding.rst
binste 4ca2084
Update doc/user_guide/encoding.rst
binste 92549a9
Update doc/user_guide/encoding.rst
binste b9b3258
Update doc/user_guide/encoding.rst
binste 6dbe37a
Fix usage of alt.value in rule example
binste ceea0b0
Merge branch 'master' into improve_encoding_sections
binste 01c5dd4
Move section on themes from configuration to customization page
binste e485e49
Collapse object tables by default
binste a42f7db
Move encodings page into subfolder
binste 77677b2
Move content on channels and channel options into separate subpages
binste 1be0fd7
Introduce both concepts of a channel and channel options in the begin…
binste 2c89913
Format code
binste 2d01fa1
Minor language improvements
binste 9399659
Update doc/user_guide/encodings/index.rst
binste 7a76bef
Update doc/user_guide/encodings/index.rst
binste 495a0ee
Update doc/user_guide/encodings/index.rst
binste f69cb96
Update doc/user_guide/encodings/index.rst
binste 2dcdc69
Update doc/user_guide/encodings/index.rst
binste 1b53c09
Update doc/user_guide/encodings/index.rst
binste 4932b0e
Update doc/user_guide/encodings/channels.rst
binste c68eb97
Add reference to faceted charts section
binste 20568e0
Add introductory sentences before tables
binste File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page is so nice to read with the collapsed tables! I noticed there were just a few sections that were missing a sentence introducing the tables, could we add these:
Can we use the same wording for projection and selection as for scale ranges ("Projections can be configured using..."):
The table in the Header section is missing a leading sentence, could we add something like "Additional properties are summarized in the following table:"