Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Make rendering optional for tutorial #2925

Merged
merged 3 commits into from
Feb 26, 2023
Merged

docs: Make rendering optional for tutorial #2925

merged 3 commits into from
Feb 26, 2023

Conversation

dylancashman
Copy link
Contributor

Addresses #2911 - makes intro example tutorial not require reading about renderers.

@dylancashman dylancashman mentioned this pull request Feb 24, 2023
Closed
joelostblom
joelostblom requested changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I made a suggestion to indicate that Jlab and VSCode works by default, let me know what you think about it.

doc/getting_started/starting.rst Outdated Show resolved Hide resolved
mattijn and others added 2 commits February 26, 2023 22:46
@mattijn
Merge branch 'master' into intro-doc-update
55b6e27
@mattijn @joelostblom
Update doc/getting_started/starting.rst
02fd231 
Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
@mattijn
Copy link
Contributor

mattijn commented Feb 26, 2023

Thanks @dylancashman!

@mattijn mattijn merged commit c624f80 into vega:master Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelostblom joelostblom joelostblom requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dylancashman @mattijn @joelostblom