Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display more helpful error message when two fields strings are used in condition #2979

Merged
merged 7 commits into from
Mar 26, 2023
Merged

Display more helpful error message when two fields strings are used in condition #2979

merged 7 commits into from
Mar 26, 2023

Commits on Mar 26, 2023

  1. Raise helpful error if a field is used in both branches of a condition

    @joelostblom
    joelostblom committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    be1d70b View commit details
    Browse the repository at this point in the history

  2. Add test

    @joelostblom
    joelostblom committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    3a0caa9 View commit details
    Browse the repository at this point in the history

  3. Add changelog entry

    @joelostblom
    joelostblom committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    ca0ffb6 View commit details
    Browse the repository at this point in the history

  4. Blacken

    @joelostblom
    joelostblom committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    c77b59e View commit details
    Browse the repository at this point in the history

  5. Blacken more

    @joelostblom
    joelostblom committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    ed59830 View commit details
    Browse the repository at this point in the history

  6. Improve error message wording

    @joelostblom
    joelostblom committed Mar 26, 2023
    Configuration menu
    Copy the full SHA
    50c12f7 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Mattijn van Hoek <mattijn@gmail.com>
    @joelostblom @mattijn
    joelostblom and mattijn authored Mar 26, 2023
    Configuration menu
    Copy the full SHA
    0b162a7 View commit details
    Browse the repository at this point in the history