Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update UserGuide: Add Rotate Axis, Sort Legend Example, Citing Section #3217

Merged
merged 12 commits into from
Oct 16, 2023

Conversation

ChiaLingWeng
Copy link
Contributor

@ChiaLingWeng ChiaLingWeng commented Oct 5, 2023

This will close #3182 , #1961 and #2660 .
Rotate axis title example:
image

close #1961
Sort legend by specific data example:
image

close #2660
Add Citing section under About tab
image

Rita Weng and others added 4 commits October 5, 2023 09:55
@ChiaLingWeng ChiaLingWeng changed the title [Doc] Update UserGuide: Add Rotate Axis Method [Doc] Update UserGuide: Add Rotate Axis, Sort Legend Example Oct 5, 2023
@ChiaLingWeng ChiaLingWeng changed the title [Doc] Update UserGuide: Add Rotate Axis, Sort Legend Example [Doc] Update UserGuide: Add Rotate Axis, Sort Legend Example, Citing Section Oct 5, 2023
Copy link
Contributor

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @ChiaLingWeng ! I made a few edits for the legend sorting section that were out of date since previously. I just have one comment on the axis label rotation and then we can merge

doc/user_guide/customization.rst Outdated Show resolved Hide resolved
Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
@ChiaLingWeng
Copy link
Contributor Author

Yes @joelostblom I did not notice not! Change accepted.

@joelostblom joelostblom merged commit c915818 into vega:main Oct 16, 2023
10 checks passed
@joelostblom
Copy link
Contributor

This looks great, thanks again @ChiaLingWeng ! I made a small fix and merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants