fix: Support falling back to pandas when pyarrow is installed but too old #3387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How can we report to a user if the version of pyarrow is too low when pandas is explicitly not installed? |
jonmmease
changed the title
I guess this is something we would want to work into your PR at #3384 |
|
Valid point! |
|
Ready for this to merge @mattijn? |
|
I haven't had time to test this, but the fix looks legitimate and appropriate👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3385 by catching
RuntimeErroralong withImportErrorinpyarrow_available.This was a regression introduced in #3244 when the
ImportErrorwas swapped out for aRuntimeErrorwithout updatingpyarrow_available.@mattijn, could you give this a try to see if it takes care of the issue of an old pyarrow with pandas?