-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace archived m2r
with updated mistune
#3506
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the 2nd of two references to `m2r`, but is only needed due to using `m2r`. Should simplify finding a replacement for `m2r.convert`
Identicial operation, but now much clearer it is an extension to `mistune`
See module docstring on this commit. Planning to reduce to the smallest number of components and then update to `mistune==3.0.2`
The included `RSTRenderer` required one minor change. The rest of the differences I think were errors in the original
Thanks! Really nice to read through the commits one by one to follow the proces. And I like the bonus too! |
Thanks @mattijn It was an interesting journey to get there, but surprisingly few changes (in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dev
dependency m2r was archived on 2022-11-17.The most popular fork m2r2 was last updated on 2023-01-30.
m2r
was used to convert markdown to rst, extending https://github.com/lepture/mistune/releases/tag/v0.8.4This functionality is part of the current version of
mistune
mistune==0.8.4
currently raises the following error during doc:built-html:Changes
Most of the diff is due to
m2r
inserting whitespace where it wasn't needed.As a bonus, some bulleted lists that appear within a parameter description are now formatted correctly.
Before -> After