fix: fix sveltekit vega import (#935)

* fix: fix sveltekit vega import * bump packages
vega · May 10, 2024 · d04cfe7 · d04cfe7
1 parent 5db9ada
commit d04cfe7
Show file tree

Hide file tree

Showing 6 changed files with 1,446 additions and 1,228 deletions.
diff --git a/packages/storybook/package.json b/packages/storybook/package.json
@@ -24,12 +24,13 @@
 		"svelte": "^4.2.15",
 		"svelte-vega": "^1.2.0",
 		"vega": "^5.28.0",
-		"vega-lite": "^5.17.0"
+		"vega-embed": "^6.25.0",
+		"vega-lite": "^5.18.1"
 	},
 	"devDependencies": {
+		"@babel/core": "^7.24.3",
 		"@storybook/cli": "^7.6.12",
 		"@storybook/svelte-vite": "^7.6.12",
-		"@babel/core": "^7.24.3",
 		"gh-pages": "^6.1.1",
 		"storybook": "^7.6.12",
 		"svelte-check": "^3.6.8",

diff --git a/packages/svelte-vega-sample/package.json b/packages/svelte-vega-sample/package.json
@@ -12,16 +12,17 @@
 	"dependencies": {
 		"svelte-vega": "^1.2.0",
 		"tslib": "^2.6.2",
-		"vega-lite": "^5.17.0",
-		"vega": "^5.28.0"
+		"vega": "^5.28.0",
+		"vega-embed": "^6.25.0",
+		"vega-lite": "^5.17.0"
 	},
 	"devDependencies": {
 		"@sveltejs/vite-plugin-svelte": "^3.0.2",
 		"@tsconfig/svelte": "^5.0.2",
+		"svelte": "^4.2.15",
 		"svelte-check": "^3.6.8",
 		"svelte-preprocess": "^5.1.3",
-		"vite": "^4.4.9",
-		"svelte": "^4.2.15",
-		"typescript": "^5.4.2"
+		"typescript": "^5.4.2",
+		"vite": "^5.0.3"
 	}
 }
diff --git a/packages/svelte-vega/package.json b/packages/svelte-vega/package.json
@@ -42,8 +42,7 @@
 		"!dist/**/*.spec.*"
 	],
 	"dependencies": {
-		"fast-deep-equal": "^3.1.3",
-		"vega-embed": "^6.24.0"
+		"fast-deep-equal": "^3.1.3"
 	},
 	"devDependencies": {
 		"@sveltejs/adapter-auto": "^3.2.0",
@@ -60,13 +59,14 @@
 		"svelte": "^4.2.15",
 		"svelte-check": "^3.6.8",
 		"tslib": "^2.6.2",
-		"vite": "^4.4.9",
+		"vite": "^5.0.3",
 		"typescript": "^5.4.2"
 	},
 	"peerDependencies": {
 		"svelte": "^3.54.0 || ^4.0.0",
 		"vega": "*",
-		"vega-lite": "*"
+		"vega-lite": "*",
+		"vega-embed": "*"
 	},
 	"publishConfig": {
 		"access": "public"

diff --git a/packages/svelte-vega/src/lib/utils.ts b/packages/svelte-vega/src/lib/utils.ts
@@ -1,7 +1,7 @@
-import type { View, SignalListeners } from './types';
-import { vega } from 'vega-embed';
 import equal from 'fast-deep-equal';
-import type { VisualizationSpec, EmbedOptions } from 'vega-embed';
+import * as vega from 'vega';
+import type { EmbedOptions, VisualizationSpec } from 'vega-embed';
+import type { SignalListeners, View } from './types';
 
 export function updateMultipleDatasetsInView(view: View, data: Record<string, unknown>): void {
 	for (const [name, value] of Object.entries(data)) {

diff --git a/packages/sveltekit-vega-sample/package.json b/packages/sveltekit-vega-sample/package.json
@@ -15,8 +15,11 @@
 		"svelte": "^4.2.15",
 		"svelte-check": "^3.6.8",
 		"tslib": "^2.6.2",
-		"vite": "^4.4.9",
-		"typescript": "^5.4.2"
+		"typescript": "^5.4.2",
+		"vite": "^5.0.3"
 	},
-	"type": "module"
+	"type": "module",
+	"dependencies": {
+		"vega-embed": "^6.25.0"
+	}
 }