Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change syntax to svelte 5 #972

Merged
merged 6 commits into from
Nov 11, 2024
Merged

refactor: change syntax to svelte 5 #972

merged 6 commits into from
Nov 11, 2024

Conversation

Sparkier
Copy link
Collaborator

@Sparkier Sparkier commented Nov 9, 2024

Changes the syntax of all svelte files to Svelte 5.

@Sparkier Sparkier requested a review from domoritz November 9, 2024 17:28
domoritz
domoritz reviewed Nov 9, 2024
View reviewed changes
Copy link
Member

@domoritz domoritz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Should we remove the class compatibility mode I added recently? See packages/svelte-vega/svelte.config.js at the bottom for example.

yarn.lock
@@ -5973,6 +5973,14 @@ svelte-preprocess@^6.0.3:
resolved "https://registry.yarnpkg.com/svelte-preprocess/-/svelte-preprocess-6.0.3.tgz#fdc1f9dc41b6f22bf8b1f059e9f21eaaae181eeb"
integrity sha512-PLG2k05qHdhmRG7zR/dyo5qKvakhm8IJ+hD2eFRQmMLHp7X3eJnjeupUtvuRpbNiF31RjVw45W+abDwHEmP5OA==

svelte-vega@^1.2.0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird. Probably shouldn't be here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm thats's what I get when I run yarn on the monorepo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to indicate that we don't use the dependency from this repo somehow.

packages/svelte-vega-sample/src/App.svelte Show resolved Hide resolved
@Sparkier Sparkier requested a review from domoritz November 10, 2024 03:22
domoritz
domoritz reviewed Nov 10, 2024
View reviewed changes
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to change the dependency to only allow svelte 5 now. So this is a breaking change.

@domoritz
Copy link
Member

This needs to be fixed before we can merge.

Screenshot 2024-11-11 at 10 57 08

@Sparkier
Copy link
Collaborator Author

This needs to be fixed before we can merge.

Screenshot 2024-11-11 at 10 57 08

Done

@domoritz
Copy link
Member

Thanks. yarn sample:sveltekit still doesn't work but that wasn't working before either.

@domoritz domoritz merged commit a4d6eae into main Nov 11, 2024
1 check passed
@domoritz domoritz deleted the ab-svelte-5 branch November 11, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sparkier @domoritz