Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add git to required packages #66

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

imlonghao
Copy link
Contributor

The action docker/build-push-action build Docker images with buildx.

The docker-build is something like remote-build, it runs the build process on the remote host.
In this case, we need git in the Docker-In-Docker container image.

Close #57

@sebthom
Copy link
Member

sebthom commented Oct 21, 2024

Could we make this conditional? That it is only installed for the dind image?

@imlonghao
Copy link
Contributor Author

I moved the git installation under $FLAVOR == dind*, only dind image need git.

@sebthom sebthom merged commit 7c9b6cd into vegardit:main Oct 21, 2024
6 checks passed
@sebthom
Copy link
Member

sebthom commented Oct 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

dind-rootless-latest need git as dependency
3 participants