feat(gqlerror): optimize Error method perfomance (#328)

vektah · Oct 25, 2024 · 89fc137 · 89fc137
1 parent 6361a74
commit 89fc137
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/gqlerror/error.go b/gqlerror/error.go
@@ -1,10 +1,10 @@
 package gqlerror
 
 import (
-	"bytes"
 	"errors"
 	"fmt"
 	"strconv"
+	"strings"
 
 	"github.com/vektah/gqlparser/v2/ast"
 )
@@ -38,7 +38,7 @@ type Location struct {
 type List []*Error
 
 func (err *Error) Error() string {
-	var res bytes.Buffer
+	var res strings.Builder
 	if err == nil {
 		return ""
 	}
@@ -80,7 +80,7 @@ func (err *Error) AsError() error {
 }
 
 func (errs List) Error() string {
-	var buf bytes.Buffer
+	var buf strings.Builder
 	for _, err := range errs {
 		buf.WriteString(err.Error())
 		buf.WriteByte('\n')

diff --git a/gqlerror/error_test.go b/gqlerror/error_test.go
@@ -5,6 +5,7 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/require"
+
 	"github.com/vektah/gqlparser/v2/ast"
 )
 
@@ -166,3 +167,13 @@ func TestList_Is(t *testing.T) {
 		})
 	}
 }
+
+func BenchmarkError(b *testing.B) {
+	list := List([]*Error{error1, error2})
+	for i := 0; i < b.N; i++ {
+		_ = underlyingError.Error()
+		_ = error1.Error()
+		_ = error2.Error()
+		_ = list.Error()
+	}
+}