Disallow empty parens (#292). #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchenshi
commented
Apr 5, 2024
| @@ -80,6 +80,15 @@ object types: | |||
| message: 'Name "__id" must not begin with "__", which is reserved by GraphQL introspection.' | |||
| locations: [{line: 2, column: 3}] | |||
|
|
|||
| - name: field argument list must not be empty | |||
There was a problem hiding this comment.
This test merely documents the existing behavior, which is already correct (spec compliant). It's just for additional test coverage. The other two tests are for the fixes in this PR.
|
Thanks! |
andaaron
added a commit
to rchincha/zot
that referenced
this pull request
Jun 4, 2024
See vektah/gqlparser#292 and vektah/gqlparser#293 Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
andaaron
added a commit
to rchincha/zot
that referenced
this pull request
Jun 4, 2024
Fix also some tests See vektah/gqlparser#292 and vektah/gqlparser#293 Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
andaaron
added a commit
to project-zot/zot
that referenced
this pull request
Jun 4, 2024
* chore: fix dependabot alerts #2435 #2436 #2437 #2438 #2439 #2440 #2441 #2442 #2443 #2444 #2445 Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com> * fix(zli): _schema query in zli code should not use empty parens Fix also some tests See vektah/gqlparser#292 and vektah/gqlparser#293 Signed-off-by: Andrei Aaron <aaaron@luxoft.com> --------- Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com> Signed-off-by: Andrei Aaron <aaaron@luxoft.com> Co-authored-by: Andrei Aaron <aaaron@luxoft.com>
github-merge-queue bot
referenced
this pull request
in infratographer/x
Aug 8, 2024
…ecurity] (#238) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/vektah/gqlparser/v2](https://togithub.com/vektah/gqlparser) | `v2.5.11` -> `v2.5.14` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | ### GitHub Vulnerability Alerts #### [CVE-2023-49559](https://nvd.nist.gov/vuln/detail/CVE-2023-49559) An issue in vektah gqlparser open-source-library v.2.5.10 allows a remote attacker to cause a denial of service via a crafted script to the parserDirectives function. --- ### Release Notes <details> <summary>vektah/gqlparser (github.com/vektah/gqlparser/v2)</summary> ### [`v2.5.14`](https://togithub.com/vektah/gqlparser/releases/tag/v2.5.14) [Compare Source](https://togithub.com/vektah/gqlparser/compare/v2.5.13...v2.5.14) #### What's Changed - Add ParseQueryWithLimit by [@​StevenACoffman](https://togithub.com/StevenACoffman) in [https://github.com/vektah/gqlparser/pull/304](https://togithub.com/vektah/gqlparser/pull/304) **Full Changelog**: vektah/gqlparser@v2.5.13...v2.5.14 ### [`v2.5.13`](https://togithub.com/vektah/gqlparser/releases/tag/v2.5.13) [Compare Source](https://togithub.com/vektah/gqlparser/compare/v2.5.12...v2.5.13) #### What's Changed - Bump the actions-deps group in /validator/imported with 6 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vektah/gqlparser/pull/298](https://togithub.com/vektah/gqlparser/pull/298) - Bump prettier from 3.2.5 to 3.3.0 in /validator/imported in the actions-deps group by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vektah/gqlparser/pull/299](https://togithub.com/vektah/gqlparser/pull/299) - Bump the actions-deps group in /validator/imported with 7 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vektah/gqlparser/pull/301](https://togithub.com/vektah/gqlparser/pull/301) - Bump braces from 3.0.2 to 3.0.3 in /validator/imported by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vektah/gqlparser/pull/302](https://togithub.com/vektah/gqlparser/pull/302) - Token limit fix CVE-2023-49559 by [@​uvzz](https://togithub.com/uvzz) in [https://github.com/vektah/gqlparser/pull/291](https://togithub.com/vektah/gqlparser/pull/291) #### New Contributors - [@​uvzz](https://togithub.com/uvzz) made their first contribution in [https://github.com/vektah/gqlparser/pull/291](https://togithub.com/vektah/gqlparser/pull/291) **Full Changelog**: vektah/gqlparser@v2.5.12...v2.5.13 ### [`v2.5.12`](https://togithub.com/vektah/gqlparser/releases/tag/v2.5.12) [Compare Source](https://togithub.com/vektah/gqlparser/compare/v2.5.11...v2.5.12) ##### What's Changed - Disallow empty parens ([#​292](https://togithub.com/vektah/gqlparser/issues/292)). by [@​yuchenshi](https://togithub.com/yuchenshi) in [https://github.com/vektah/gqlparser/pull/293](https://togithub.com/vektah/gqlparser/pull/293) - WithBuiltin FormatterOption added by [@​atzedus](https://togithub.com/atzedus) in [https://github.com/vektah/gqlparser/pull/294](https://togithub.com/vektah/gqlparser/pull/294) - Redo github actions by [@​StevenACoffman](https://togithub.com/StevenACoffman) in [https://github.com/vektah/gqlparser/pull/295](https://togithub.com/vektah/gqlparser/pull/295) - Bump github.com/stretchr/testify from 1.4.0 to 1.9.0 in the actions-deps group by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vektah/gqlparser/pull/296](https://togithub.com/vektah/gqlparser/pull/296) - Bump the actions-deps group in /validator/imported with 8 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/vektah/gqlparser/pull/297](https://togithub.com/vektah/gqlparser/pull/297) ##### New Contributors - [@​yuchenshi](https://togithub.com/yuchenshi) made their first contribution in [https://github.com/vektah/gqlparser/pull/293](https://togithub.com/vektah/gqlparser/pull/293) **Full Changelog**: vektah/gqlparser@v2.5.11...v2.5.12 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/infratographer/x). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xOC4xNyIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE3IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disallows empty parens in variables and argument lists in operations according to GQL spec. See #292.
I have: