-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Outer ] 区切りに本とピラミッドを追加 #2285
Merged
Merged
[ Outer ] 区切りに本とピラミッドを追加 #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdkei
requested review from
mthaichi,
kurudrive,
sysbird,
goutetsuguma,
akito-38,
drill-lancer and
MasayaMORIMOTO
October 25, 2024 06:18
akito-38
reviewed
Oct 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
確認しました。問題無いと思います。
akito-38
approved these changes
Oct 26, 2024
akito-38
changed the title
【確認待ち】[ Outer ] 区切りに本とピラミッドを追加
【二人目確認待ち】[ Outer ] 区切りに本とピラミッドを追加
Oct 26, 2024
@mtdkei |
drill-lancer
approved these changes
Oct 28, 2024
drill-lancer
changed the title
【二人目確認待ち】[ Outer ] 区切りに本とピラミッドを追加
[ Outer ] 区切りに本とピラミッドを追加
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケットへのリンク / 変更の理由(元のissueがあればリンクを貼り付ければOK)
#1997 の本とピラミッド
どういう変更をしたか?
Outerの区切り線にBookとピラミッドを追加しました。
スクリーンショットまたは動画
変更前 Before
変更後 After
実装者の確認事項
実装者はレビュワーに回す前に以下の事を確認してチェックをつけてください。
プログラムの変更の場合
テストを書かないのは普通ではありません。書けるテストは極力書くようにしてください。
変更内容について何を確認したか、どういう方法で確認をしたかなど
なお、ギザギザはマイナスの時もプラスと同じ表示になります。
レビュワーに回す前の確認事項
レビュワー確認方法・確認内容など
実装者と同じ確認を行なってください。
レビュワー向け
レビュワーが確認して変更が反映されていない場合の確認事項
レビューしてみて意図した動作をしない場合は再度ビルドするなど以下の項目を確認してください。