Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ タブ ] Lightningテーマのcssに負ける場合があるため、優先度をあげる目的でクラス名を追加 #2382

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

goutetsuguma
Copy link
Contributor

@goutetsuguma goutetsuguma commented Dec 20, 2024

チケットへのリンク / 変更の理由(元のissueがあればリンクを貼り付ければOK)

#2377

どういう変更をしたか?

Lightningテーマでtheme.json を有効化して世代はG3の場合、グループブロック内にタブブロックを配置すると、テーマ側のcssのmarginが付与されてしまうので、優先度をあげる目的でクラス名を追加しました。

スクリーンショットまたは動画

変更前 Before

スクリーンショット 2024-12-20 14 35 31

変更後 After

スクリーンショット 2024-12-20 14 33 53

実装者の確認事項

実装者はレビュワーに回す前に以下の事を確認してチェックをつけてください。

  • 複数の意図の変更 ( 機能の不具合修正 + 別の機能追加など ) を含んでいないか?
  • Files changed (変更ファイル)の内容は目視で確認したか?
  • readme.txt に変更内容は書いたか?
  • 本当にちゃんと確認をしたか?

プログラムの変更の場合

テストを書かないのは普通ではありません。書けるテストは極力書くようにしてください。

  • 書けそうなテストは書いたか?
    CSSの修正のため書いておりません

変更内容について何を確認したか、どういう方法で確認をしたかなど

  • Lightningテーマのtheme.jsonは有効化で世代はGeneration3 にして、developブランチで固定ページを「コードエディタ」に変更して、以下のコードを貼ります。
<!-- wp:group {"align":"full","style":{"spacing":{"padding":{"top":"0px","bottom":"0px"}},"color":{"background":"#f5f5f5"}},"layout":{"type":"constrained"}} -->
<div class="wp-block-group alignfull has-background" style="background-color:#f5f5f5;padding-top:0px;padding-bottom:0px"><!-- wp:vk-blocks/spacer {"spaceType":"height","spaceSize":"large","className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom"} -->
<div class="wp-block-vk-blocks-spacer vk_spacer vk_spacer-type-height vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom"><div class="vk_block-margin-lg--height"></div></div>
<!-- /wp:vk-blocks/spacer -->

<!-- wp:vk-blocks/tab {"tabOptionJSON":"{\u0022listArray\u0022:[{\u0022tabLabel\u0022:\u0022新着\u0022,\u0022tabColor\u0022:\u0022#232323\u0022,\u0022blockId\u0022:\u002246359599-065e-4bab-95f2-94d9fe3e1155\u0022},{\u0022tabLabel\u0022:\u0022イベント情報\u0022,\u0022tabColor\u0022:\u0022#1e73be\u0022,\u0022blockId\u0022:\u0022a10f25d7-15b2-4fb0-83b4-a4aec3946cef\u0022},{\u0022tabLabel\u0022:\u0022営業案内\u0022,\u0022tabColor\u0022:\u0022#2e9662\u0022,\u0022blockId\u0022:\u002208272068-4875-46c1-af82-593554d86172\u0022},{\u0022tabLabel\u0022:\u0022その他のお知らせ\u0022,\u0022tabColor\u0022:\u0022#dd8500\u0022,\u0022blockId\u0022:\u0022d28d5f57-f32b-4a7e-ab8f-f630dc412d5c\u0022}],\u0022tabLabelBackground\u0022:false,\u0022tabLabelBorderTop\u0022:true,\u0022tabBodyBorderTop\u0022:false}","tabSizeSp":"monospaced","tabSizeTab":"monospaced","tabSizePc":"monospaced","tabDisplayOptionsSp":"scroll","tabDisplayOptionsTab":"scroll","tabDisplayOptionsPc":"scroll","blockId":"965c79cd-30bc-493e-a23b-c30860d03de6","className":"is-style-vk_tab_labels-line"} -->
<div class="wp-block-vk-blocks-tab vk_tab is-style-vk_tab_labels-line" id="vk-tab-id-965c79cd-30bc-493e-a23b-c30860d03de6"><ul class="vk_tab_labels vk_tab_labels--scroll-sp vk_tab_labels--scroll-tab vk_tab_labels--scroll-pc vk_tab_labels-tabSize--sp-monospaced vk_tab_labels-tabSize--tab-monospaced vk_tab_labels-tabSize--pc-monospaced" role="tablist"><li id="vk_tab_labels_label-46359599-065e-4bab-95f2-94d9fe3e1155" class="vk_tab_labels_label vk_tab_labels_label-state-active" style="color:#232323" tabindex="0" role="tab" aria-selected="true" aria-controls="vk_tab_bodys_body-46359599-065e-4bab-95f2-94d9fe3e1155"><div class=" has-border-top" style="border-top-color:#232323">新着</div></li><li id="vk_tab_labels_label-a10f25d7-15b2-4fb0-83b4-a4aec3946cef" class="vk_tab_labels_label vk_tab_labels_label-state-inactive" tabindex="-1" role="tab" aria-selected="false" aria-controls="vk_tab_bodys_body-a10f25d7-15b2-4fb0-83b4-a4aec3946cef"><div class=" has-border-top" style="border-top-color:#1e73be">イベント情報</div></li><li id="vk_tab_labels_label-08272068-4875-46c1-af82-593554d86172" class="vk_tab_labels_label vk_tab_labels_label-state-inactive" tabindex="-1" role="tab" aria-selected="false" aria-controls="vk_tab_bodys_body-08272068-4875-46c1-af82-593554d86172"><div class=" has-border-top" style="border-top-color:#2e9662">営業案内</div></li><li id="vk_tab_labels_label-d28d5f57-f32b-4a7e-ab8f-f630dc412d5c" class="vk_tab_labels_label vk_tab_labels_label-state-inactive" tabindex="-1" role="tab" aria-selected="false" aria-controls="vk_tab_bodys_body-d28d5f57-f32b-4a7e-ab8f-f630dc412d5c"><div class=" has-border-top" style="border-top-color:#dd8500">その他のお知らせ</div></li></ul><div class="vk_tab_bodys"><!-- wp:vk-blocks/tab-item {"tabLabel":"新着","tabBodyActive":true,"tabColor":"#232323","tabBodyBorderTop":false,"blockId":"46359599-065e-4bab-95f2-94d9fe3e1155"} -->
<div class="wp-block-vk-blocks-tab-item vk_tab_bodys_body vk_tab_bodys_body-state-active vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom" id="vk_tab_bodys_body-46359599-065e-4bab-95f2-94d9fe3e1155" role="tabpanel" aria-labelledby="vk_tab_labels_label-46359599-065e-4bab-95f2-94d9fe3e1155"><!-- wp:group {"className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom","style":{"border":{"style":"solid","color":"#0000001f","width":"1px","top":{"width":"0px"}},"spacing":{"padding":{"bottom":"0px","right":"2rem","top":"2rem","left":"2rem"}},"color":{"background":"#ffffff"}}} -->
<div class="wp-block-group vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom has-border-color has-background" style="border-color:#0000001f;border-style:solid;border-width:1px;border-top-width:0px;background-color:#ffffff;padding-top:2rem;padding-right:2rem;padding-bottom:0px;padding-left:2rem"><!-- wp:paragraph -->
<p>新着</p>
<!-- /wp:paragraph -->

<!-- wp:vk-blocks/spacer {"className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom"} -->
<div class="wp-block-vk-blocks-spacer vk_spacer vk_spacer-type-margin-top vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom"><div class="vk_block-margin-md--margin-top"></div></div>
<!-- /wp:vk-blocks/spacer --></div>
<!-- /wp:group --></div>
<!-- /wp:vk-blocks/tab-item -->

<!-- wp:vk-blocks/tab-item {"tabLabel":"イベント情報","tabColor":"#1e73be","tabBodyBorderTop":false,"blockId":"a10f25d7-15b2-4fb0-83b4-a4aec3946cef"} -->
<div class="wp-block-vk-blocks-tab-item vk_tab_bodys_body vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom" id="vk_tab_bodys_body-a10f25d7-15b2-4fb0-83b4-a4aec3946cef" role="tabpanel" aria-labelledby="vk_tab_labels_label-a10f25d7-15b2-4fb0-83b4-a4aec3946cef" hidden><!-- wp:group {"className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom","style":{"border":{"style":"solid","color":"#0000001f","width":"1px","top":{"width":"0px"}},"spacing":{"padding":{"bottom":"0px","right":"2rem","top":"2rem","left":"2rem"}},"color":{"background":"#ffffff"}}} -->
<div class="wp-block-group vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom has-border-color has-background" style="border-color:#0000001f;border-style:solid;border-width:1px;border-top-width:0px;background-color:#ffffff;padding-top:2rem;padding-right:2rem;padding-bottom:0px;padding-left:2rem"><!-- wp:paragraph -->
<p>イベント情報</p>
<!-- /wp:paragraph -->

<!-- wp:vk-blocks/spacer {"className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom"} -->
<div class="wp-block-vk-blocks-spacer vk_spacer vk_spacer-type-margin-top vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom"><div class="vk_block-margin-md--margin-top"></div></div>
<!-- /wp:vk-blocks/spacer --></div>
<!-- /wp:group --></div>
<!-- /wp:vk-blocks/tab-item -->

<!-- wp:vk-blocks/tab-item {"tabLabel":"営業案内","tabColor":"#2e9662","tabBodyBorderTop":false,"blockId":"08272068-4875-46c1-af82-593554d86172"} -->
<div class="wp-block-vk-blocks-tab-item vk_tab_bodys_body vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom" id="vk_tab_bodys_body-08272068-4875-46c1-af82-593554d86172" role="tabpanel" aria-labelledby="vk_tab_labels_label-08272068-4875-46c1-af82-593554d86172" hidden><!-- wp:group {"className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom","style":{"border":{"style":"solid","color":"#0000001f","width":"1px","top":{"width":"0px"}},"spacing":{"padding":{"bottom":"0px","right":"2rem","top":"2rem","left":"2rem"}},"color":{"background":"#ffffff"}}} -->
<div class="wp-block-group vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom has-border-color has-background" style="border-color:#0000001f;border-style:solid;border-width:1px;border-top-width:0px;background-color:#ffffff;padding-top:2rem;padding-right:2rem;padding-bottom:0px;padding-left:2rem"><!-- wp:paragraph -->
<p>営業案内</p>
<!-- /wp:paragraph -->

<!-- wp:vk-blocks/spacer {"className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom"} -->
<div class="wp-block-vk-blocks-spacer vk_spacer vk_spacer-type-margin-top vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom"><div class="vk_block-margin-md--margin-top"></div></div>
<!-- /wp:vk-blocks/spacer --></div>
<!-- /wp:group --></div>
<!-- /wp:vk-blocks/tab-item -->

<!-- wp:vk-blocks/tab-item {"tabLabel":"その他のお知らせ","tabColor":"#dd8500","tabBodyBorderTop":false,"blockId":"d28d5f57-f32b-4a7e-ab8f-f630dc412d5c"} -->
<div class="wp-block-vk-blocks-tab-item vk_tab_bodys_body vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom" id="vk_tab_bodys_body-d28d5f57-f32b-4a7e-ab8f-f630dc412d5c" role="tabpanel" aria-labelledby="vk_tab_labels_label-d28d5f57-f32b-4a7e-ab8f-f630dc412d5c" hidden><!-- wp:group {"className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom","style":{"border":{"style":"solid","color":"#0000001f","width":"1px","top":{"width":"0px"}},"spacing":{"padding":{"bottom":"0px","right":"2rem","top":"2rem","left":"2rem"}},"color":{"background":"#ffffff"}}} -->
<div class="wp-block-group vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom has-border-color has-background" style="border-color:#0000001f;border-style:solid;border-width:1px;border-top-width:0px;background-color:#ffffff;padding-top:2rem;padding-right:2rem;padding-bottom:0px;padding-left:2rem"><!-- wp:paragraph -->
<p>その他のお知らせ</p>
<!-- /wp:paragraph -->

<!-- wp:vk-blocks/spacer {"className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom"} -->
<div class="wp-block-vk-blocks-spacer vk_spacer vk_spacer-type-margin-top vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom"><div class="vk_block-margin-md--margin-top"></div></div>
<!-- /wp:vk-blocks/spacer --></div>
<!-- /wp:group --></div>
<!-- /wp:vk-blocks/tab-item --></div></div>
<!-- /wp:vk-blocks/tab -->

<!-- wp:vk-blocks/spacer {"spaceType":"height","className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom"} -->
<div class="wp-block-vk-blocks-spacer vk_spacer vk_spacer-type-height vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom"><div class="vk_block-margin-md--height"></div></div>
<!-- /wp:vk-blocks/spacer -->

<!-- wp:vk-blocks/tab {"tabOptionJSON":"{\u0022listArray\u0022:[{\u0022tabLabel\u0022:\u0022新着\u0022,\u0022tabColor\u0022:\u0022#232323\u0022,\u0022blockId\u0022:\u0022e47a874c-f753-41d7-b786-a84097fc6540\u0022},{\u0022tabLabel\u0022:\u0022イベント情報\u0022,\u0022tabColor\u0022:\u0022#1e73be\u0022,\u0022blockId\u0022:\u002210ddccf5-1c36-4d66-b2e4-55deb9268992\u0022},{\u0022tabLabel\u0022:\u0022営業案内\u0022,\u0022tabColor\u0022:\u0022#2e9662\u0022,\u0022blockId\u0022:\u0022ff058c47-99f4-4534-be20-db10f0cc23c8\u0022},{\u0022tabLabel\u0022:\u0022その他のお知らせ\u0022,\u0022tabColor\u0022:\u0022#dd8500\u0022,\u0022blockId\u0022:\u0022f4ad0e6a-8f66-4b57-8fb2-69032f717133\u0022}],\u0022tabLabelBackground\u0022:true,\u0022tabLabelBorderTop\u0022:false,\u0022tabBodyBorderTop\u0022:true}","tabSizeSp":"monospaced","tabSizeTab":"monospaced","tabSizePc":"monospaced","tabDisplayOptionsSp":"scroll","tabDisplayOptionsTab":"scroll","tabDisplayOptionsPc":"scroll","blockId":"15ec279e-9c50-4437-8c74-79bf7ca10d75","className":"is-style-vk_tab_labels-normal"} -->
<div class="wp-block-vk-blocks-tab vk_tab is-style-vk_tab_labels-normal" id="vk-tab-id-15ec279e-9c50-4437-8c74-79bf7ca10d75"><ul class="vk_tab_labels vk_tab_labels--scroll-sp vk_tab_labels--scroll-tab vk_tab_labels--scroll-pc vk_tab_labels-tabSize--sp-monospaced vk_tab_labels-tabSize--tab-monospaced vk_tab_labels-tabSize--pc-monospaced" role="tablist"><li id="vk_tab_labels_label-e47a874c-f753-41d7-b786-a84097fc6540" class="vk_tab_labels_label vk_tab_labels_label-state-active has-background" style="background-color:#232323" tabindex="0" role="tab" aria-selected="true" aria-controls="vk_tab_bodys_body-e47a874c-f753-41d7-b786-a84097fc6540"><div class="">新着</div></li><li id="vk_tab_labels_label-10ddccf5-1c36-4d66-b2e4-55deb9268992" class="vk_tab_labels_label vk_tab_labels_label-state-inactive has-background" style="background-color:#1e73be" tabindex="-1" role="tab" aria-selected="false" aria-controls="vk_tab_bodys_body-10ddccf5-1c36-4d66-b2e4-55deb9268992"><div class="">イベント情報</div></li><li id="vk_tab_labels_label-ff058c47-99f4-4534-be20-db10f0cc23c8" class="vk_tab_labels_label vk_tab_labels_label-state-inactive has-background" style="background-color:#2e9662" tabindex="-1" role="tab" aria-selected="false" aria-controls="vk_tab_bodys_body-ff058c47-99f4-4534-be20-db10f0cc23c8"><div class="">営業案内</div></li><li id="vk_tab_labels_label-f4ad0e6a-8f66-4b57-8fb2-69032f717133" class="vk_tab_labels_label vk_tab_labels_label-state-inactive has-background" style="background-color:#dd8500" tabindex="-1" role="tab" aria-selected="false" aria-controls="vk_tab_bodys_body-f4ad0e6a-8f66-4b57-8fb2-69032f717133"><div class="">その他のお知らせ</div></li></ul><div class="vk_tab_bodys"><!-- wp:vk-blocks/tab-item {"tabLabel":"新着","tabBodyActive":true,"tabColor":"#232323","blockId":"e47a874c-f753-41d7-b786-a84097fc6540"} -->
<div class="wp-block-vk-blocks-tab-item vk_tab_bodys_body vk_tab_bodys_body-state-active has-border-top vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom" id="vk_tab_bodys_body-e47a874c-f753-41d7-b786-a84097fc6540" style="border-top-color:#232323" role="tabpanel" aria-labelledby="vk_tab_labels_label-e47a874c-f753-41d7-b786-a84097fc6540"><!-- wp:group {"className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom","style":{"border":{"style":"solid","color":"#0000001f","width":"1px","top":{"width":"0px"}},"spacing":{"padding":{"bottom":"0px","right":"2rem","top":"2rem","left":"2rem"}},"color":{"background":"#ffffff"}}} -->
<div class="wp-block-group vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom has-border-color has-background" style="border-color:#0000001f;border-style:solid;border-width:1px;border-top-width:0px;background-color:#ffffff;padding-top:2rem;padding-right:2rem;padding-bottom:0px;padding-left:2rem"><!-- wp:paragraph -->
<p>新着</p>
<!-- /wp:paragraph -->

<!-- wp:vk-blocks/spacer {"className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom"} -->
<div class="wp-block-vk-blocks-spacer vk_spacer vk_spacer-type-margin-top vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom"><div class="vk_block-margin-md--margin-top"></div></div>
<!-- /wp:vk-blocks/spacer --></div>
<!-- /wp:group --></div>
<!-- /wp:vk-blocks/tab-item -->

<!-- wp:vk-blocks/tab-item {"tabLabel":"イベント情報","tabColor":"#1e73be","blockId":"10ddccf5-1c36-4d66-b2e4-55deb9268992"} -->
<div class="wp-block-vk-blocks-tab-item vk_tab_bodys_body has-border-top vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom" id="vk_tab_bodys_body-10ddccf5-1c36-4d66-b2e4-55deb9268992" style="border-top-color:#1e73be" role="tabpanel" aria-labelledby="vk_tab_labels_label-10ddccf5-1c36-4d66-b2e4-55deb9268992" hidden><!-- wp:group {"className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom","style":{"border":{"style":"solid","color":"#0000001f","width":"1px","top":{"width":"0px"}},"spacing":{"padding":{"bottom":"0px","right":"2rem","top":"2rem","left":"2rem"}},"color":{"background":"#ffffff"}}} -->
<div class="wp-block-group vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom has-border-color has-background" style="border-color:#0000001f;border-style:solid;border-width:1px;border-top-width:0px;background-color:#ffffff;padding-top:2rem;padding-right:2rem;padding-bottom:0px;padding-left:2rem"><!-- wp:paragraph -->
<p>イベント情報</p>
<!-- /wp:paragraph -->

<!-- wp:vk-blocks/spacer {"className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom"} -->
<div class="wp-block-vk-blocks-spacer vk_spacer vk_spacer-type-margin-top vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom"><div class="vk_block-margin-md--margin-top"></div></div>
<!-- /wp:vk-blocks/spacer --></div>
<!-- /wp:group --></div>
<!-- /wp:vk-blocks/tab-item -->

<!-- wp:vk-blocks/tab-item {"tabLabel":"営業案内","tabColor":"#2e9662","blockId":"ff058c47-99f4-4534-be20-db10f0cc23c8"} -->
<div class="wp-block-vk-blocks-tab-item vk_tab_bodys_body has-border-top vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom" id="vk_tab_bodys_body-ff058c47-99f4-4534-be20-db10f0cc23c8" style="border-top-color:#2e9662" role="tabpanel" aria-labelledby="vk_tab_labels_label-ff058c47-99f4-4534-be20-db10f0cc23c8" hidden><!-- wp:group {"className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom","style":{"border":{"style":"solid","color":"#0000001f","width":"1px","top":{"width":"0px"}},"spacing":{"padding":{"bottom":"0px","right":"2rem","top":"2rem","left":"2rem"}},"color":{"background":"#ffffff"}}} -->
<div class="wp-block-group vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom has-border-color has-background" style="border-color:#0000001f;border-style:solid;border-width:1px;border-top-width:0px;background-color:#ffffff;padding-top:2rem;padding-right:2rem;padding-bottom:0px;padding-left:2rem"><!-- wp:paragraph -->
<p>営業案内</p>
<!-- /wp:paragraph -->

<!-- wp:vk-blocks/spacer {"className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom"} -->
<div class="wp-block-vk-blocks-spacer vk_spacer vk_spacer-type-margin-top vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom"><div class="vk_block-margin-md--margin-top"></div></div>
<!-- /wp:vk-blocks/spacer --></div>
<!-- /wp:group --></div>
<!-- /wp:vk-blocks/tab-item -->

<!-- wp:vk-blocks/tab-item {"tabLabel":"その他のお知らせ","tabColor":"#dd8500","blockId":"f4ad0e6a-8f66-4b57-8fb2-69032f717133"} -->
<div class="wp-block-vk-blocks-tab-item vk_tab_bodys_body has-border-top vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom" id="vk_tab_bodys_body-f4ad0e6a-8f66-4b57-8fb2-69032f717133" style="border-top-color:#dd8500" role="tabpanel" aria-labelledby="vk_tab_labels_label-f4ad0e6a-8f66-4b57-8fb2-69032f717133" hidden><!-- wp:group {"className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom","style":{"border":{"style":"solid","color":"#0000001f","width":"1px","top":{"width":"0px"}},"spacing":{"padding":{"bottom":"0px","right":"2rem","top":"2rem","left":"2rem"}},"color":{"background":"#ffffff"}}} -->
<div class="wp-block-group vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom has-border-color has-background" style="border-color:#0000001f;border-style:solid;border-width:1px;border-top-width:0px;background-color:#ffffff;padding-top:2rem;padding-right:2rem;padding-bottom:0px;padding-left:2rem"><!-- wp:paragraph -->
<p>その他のお知らせ</p>
<!-- /wp:paragraph -->

<!-- wp:vk-blocks/spacer {"className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom"} -->
<div class="wp-block-vk-blocks-spacer vk_spacer vk_spacer-type-margin-top vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom"><div class="vk_block-margin-md--margin-top"></div></div>
<!-- /wp:vk-blocks/spacer --></div>
<!-- /wp:group --></div>
<!-- /wp:vk-blocks/tab-item --></div></div>
<!-- /wp:vk-blocks/tab -->

<!-- wp:vk-blocks/spacer {"spaceType":"height","spaceSize":"large","className":"vk_block-margin-0\u002d\u002dmargin-top vk_block-margin-0\u002d\u002dmargin-bottom"} -->
<div class="wp-block-vk-blocks-spacer vk_spacer vk_spacer-type-height vk_block-margin-0--margin-top vk_block-margin-0--margin-bottom"><div class="vk_block-margin-lg--height"></div></div>
<!-- /wp:vk-blocks/spacer --></div>
<!-- /wp:group -->
  • タブの下に余白が空いていることを確認できたら、このブランチに切り替えてタブの下に余白が空かないことを確認しました。

レビュワーに回す前の確認事項

  • 実装者はこのテンプレートのチェック項目をちゃんと確認してチェックしたか?

レビュワー確認方法・確認内容など

  • 実装者と同じ方法で確認をお願いします。

レビュワー向け

レビュワーが確認して変更が反映されていない場合の確認事項

レビューしてみて意図した動作をしない場合は再度ビルドするなど以下の項目を確認してください。

  • プルしたか?
  • ビルドしたか?
  • ビルドしたディレクトリは正しいか(別の開発環境のディレクトリを見ていないか)?
  • npm install したか?
  • composer install したか?
  • キャッシュをクリアして確認したか?

@MasayaMORIMOTO MasayaMORIMOTO changed the title [ タブ ] Lightningテーマのcssに負ける場合があるため、優先度をあげる目的でクラス名を追加 【確認中】[ タブ ] Lightningテーマのcssに負ける場合があるため、優先度をあげる目的でクラス名を追加 Dec 21, 2024
Copy link
Collaborator

@MasayaMORIMOTO MasayaMORIMOTO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作確認しました。問題ありません。
2人目の方、よろしくお願いします。

@MasayaMORIMOTO MasayaMORIMOTO changed the title 【確認中】[ タブ ] Lightningテーマのcssに負ける場合があるため、優先度をあげる目的でクラス名を追加 【2人目確認待ち】[ タブ ] Lightningテーマのcssに負ける場合があるため、優先度をあげる目的でクラス名を追加 Dec 21, 2024
@drill-lancer
Copy link
Member

問題なかったので承認後マージします。

@drill-lancer drill-lancer changed the title 【2人目確認待ち】[ タブ ] Lightningテーマのcssに負ける場合があるため、優先度をあげる目的でクラス名を追加 [ タブ ] Lightningテーマのcssに負ける場合があるため、優先度をあげる目的でクラス名を追加 Dec 23, 2024
@drill-lancer drill-lancer merged commit e4d2b78 into develop Dec 23, 2024
14 checks passed
@drill-lancer drill-lancer deleted the fix/tab-labels-margin branch December 23, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants