Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[アクセシビリティ対応] トップページ以外のサイトタイトルは段落にしました #222

Closed
wants to merge 3 commits into from
Closed

[アクセシビリティ対応] トップページ以外のサイトタイトルは段落にしました #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ace2c6c
#208
sysbird Nov 20, 2023
9cd536f
fix function name
sysbird Nov 20, 2023
5e0b515
Merge branch 'master' into fix/accessibility/heading_1
kurudrive Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions assets/_scss/_header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
.wp-block-site-title {
font-weight: bold;
line-height: var(--wp--custom--typography--line-height--heading);

Comment on lines +2 to +4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
font-weight: bold;
line-height: var(--wp--custom--typography--line-height--heading);

@sysbird CSSでの指定はできればしない方が望ましいので、theme.json の styles -> blocks に

			"core/site-title": {
				"typography": {
					"fontWeight": "700",
					"lineHeight": "var(--wp--custom--typography--line-height--heading)"
				}
			},

を追加する形でよろしくお願いいたします。

Copy link
Member Author

@sysbird sysbird Dec 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kurudrive
見ていただいてありがとうございます
同感です

このままでもいったん申請してみて、他のテーマを見てるとアクセシビリティタグ付くかも？と思います

a {
text-decoration: none;

Expand Down
222 changes: 152 additions & 70 deletions inc/patterns/header/logo-title--sns-contact__nav.php
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions parts/header-home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<!-- wp:pattern {"slug":"x-t9/header-home/logo-title--sns-contact__nav"} /-->
1 change: 1 addition & 0 deletions readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ GitHub : https://github.com/vektor-inc/x-t9

== Changelog ==

[ Specification Change ] Fix site title markup other than home for accessibility.
[ Specification Change ] Add style border radius 0 to .card
[ Translation ready ] button on featured-post-list

Expand Down
2 changes: 1 addition & 1 deletion templates/front-page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:template-part {"slug":"header","tagName":"header"} /-->
<!-- wp:template-part {"slug":"header-home","tagName":"header"} /-->

<!-- wp:group {"tagName":"main","className":"mt-0","layout":{"inherit":true}} -->
<main class="wp-block-group mt-0">
Expand Down
2 changes: 1 addition & 1 deletion templates/home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:template-part {"slug":"header","theme":"x-t9","tagName":"header"} /-->
<!-- wp:template-part {"slug":"header-home","theme":"x-t9","tagName":"header"} /-->

<!-- wp:group {"tagName":"main","className":"mt-0","layout":{"inherit":true,"type":"constrained"}} -->
<main class="wp-block-group mt-0">
Expand Down
2 changes: 1 addition & 1 deletion templates/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:template-part {"slug":"header","theme":"x-t9","tagName":"header"} /-->
<!-- wp:template-part {"slug":"header-home","theme":"x-t9","tagName":"header"} /-->

<!-- wp:group {"tagName":"main","className":"mt-0","layout":{"inherit":true,"type":"constrained"}} -->
<main class="wp-block-group mt-0">
Expand Down
5 changes: 5 additions & 0 deletions theme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,11 @@
"title": "Header",
"area": "header"
},
{
"name": "header-home",
"title": "Header Home",
"area": "header-home"
},
{
"name": "loop-archive",
"title": "Loop Archive",
Expand Down