Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #291 where a different import with the same name as the package would not get included in the mock #297

Merged
merged 1 commit into from
Jun 28, 2020

Conversation

RossHammer
Copy link
Contributor

This should fix the issue from #291. The inconsistency there came from FormatOnly being set to false when re-formating the file because it is allowed to add/remove imports.

The logic for the test that was edited came from a test that was not quite right in #143 and in turn was enforcing that this bug existed. It was kind of testing what is was looking for but not correctly so I added a proper test to validate it. I could not make the test fail with the previous code though without putting a more full pkg path in the tests.

…package would not get included in the mock
@LandonTClipp
Copy link
Collaborator

Thanks for the PR, I'll get this reviewed within the next day or so and we can get it merged.

@LandonTClipp
Copy link
Collaborator

(I haven't forgotten about this, will probably get to it on the weekend)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants