Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added swipe down to refresh #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

prati0100
Copy link

Page refreshes when swiping down from top, like Chrome

@prati0100
Copy link
Author

Why did the check fail? It complies on my system.

@jfmcbrayer
Copy link

Looks like the CI system doesn't have the needed Android SDK version.

FAILURE: Build failed with an exception.

  • What went wrong:

A problem occurred configuring project ':app'.

failed to find target android-22 : /home/travis/build/velazcod/Tinfoil-Facebook/android-sdk-linux

Copy link
Owner

@velazcod velazcod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, and my sincerest apologies for abandoning this project for so long. Will try to catch up.


//Checks if the swipe refresh indicator is active. Turns off if it is
if(mSwipeRefreshLayout.isRefreshing())
mSwipeRefreshLayout.setRefreshing(false);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if this was fully wrapped with curly brackets.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit of a newbie. I don't exactly understand by what you mean by wrapping with curly braces. Mind explaining?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. Got what you mean. I'll get it done...

@prati0100
Copy link
Author

@velazcod Is it fine now?

@Praeterii
Copy link

This is one awesome feature, we need it.

@@ -29,4 +29,9 @@
<color name="blue_primary_dark">#ff293c68</color>
<color name="blue_accent">#738ffe</color>

<color name="swipe_color_1">#33B5E5</color>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the google colors? Wouldn't be using something like blue_accent with blue_primary better looking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants