-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added swipe down to refresh #89
base: master
Are you sure you want to change the base?
Conversation
Why did the check fail? It complies on my system. |
Looks like the CI system doesn't have the needed Android SDK version. FAILURE: Build failed with an exception.
A problem occurred configuring project ':app'.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, and my sincerest apologies for abandoning this project for so long. Will try to catch up.
|
||
//Checks if the swipe refresh indicator is active. Turns off if it is | ||
if(mSwipeRefreshLayout.isRefreshing()) | ||
mSwipeRefreshLayout.setRefreshing(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer if this was fully wrapped with curly brackets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit of a newbie. I don't exactly understand by what you mean by wrapping with curly braces. Mind explaining?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind. Got what you mean. I'll get it done...
@velazcod Is it fine now? |
This is one awesome feature, we need it. |
@@ -29,4 +29,9 @@ | |||
<color name="blue_primary_dark">#ff293c68</color> | |||
<color name="blue_accent">#738ffe</color> | |||
|
|||
<color name="swipe_color_1">#33B5E5</color> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the google colors? Wouldn't be using something like blue_accent with blue_primary better looking?
Page refreshes when swiping down from top, like Chrome