-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified custom input component model #415
Labels
design 📐
This issue deals with high-level design of a feature
@vendure/admin-ui
@vendure/admin-ui-plugin
Comments
michaelbromley
added a commit
that referenced
this issue
Jul 30, 2020
michaelbromley
added a commit
that referenced
this issue
Jul 30, 2020
Relates to #415 BREAKING CHANGE: If you use custom field controls in the Admin UI, you'll need to slightly modify the component class: the `customFieldConfig` property has been renamed to `config` and a required `readonly: boolean;` field should be added. This is part of an effort to unify the way custom input components work across different parts of the Admin UI.
michaelbromley
added
the
design 📐
This issue deals with high-level design of a feature
label
Nov 11, 2020
I want the field like code of payment gateway, which are controlled by the code itself to be disabled to make changes via the admin UI because its already controlled by the code itself. Mismatches and errors may occur more if allowed edit in admin panel too. |
michaelbromley
added a commit
that referenced
this issue
Nov 26, 2021
michaelbromley
added a commit
that referenced
this issue
Nov 26, 2021
michaelbromley
added a commit
that referenced
this issue
Nov 29, 2021
michaelbromley
added a commit
that referenced
this issue
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design 📐
This issue deals with high-level design of a feature
@vendure/admin-ui
@vendure/admin-ui-plugin
Ref: #414 (comment)
In that issue, the "ideal solution", one point reads:
Now I'm thinking about this problem, and it strikes me that we can actually improve on the model used for custom field UI components, which is slightly cumbersome to work with, and always requires a UI extension to be defined (which implies the overhead of a whole Angular module etc), which is sometimes overkill.
Perhaps there is a single, consistent way to define custom input components for:
Outline
Problems to solve
vdr-text-input
) but I need to make sure there is a mechanism by which we can make a lookup in Angular based on that rather than the class itself.Examples
Here are some non-functional examples of how it might work:
Define a control on a configurable operation definition
Setting the "facetValueIds" argument of a CollectionFilter:
Define a custom field control
Override a built-in input component
If we can get something like this one working, it means we may even be able to provide a generic way to override any other built in component. E.g. a custom datatable for the orders list.
The text was updated successfully, but these errors were encountered: