Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(payments-plugin): Mollie ignore order states #2670

Merged

Conversation

martijnvdbrug
Copy link
Collaborator

@martijnvdbrug martijnvdbrug commented Feb 7, 2024

Description

In this PR we introduced order states that can be ingored when a Mollie webhook comes in, but we missed a few: Cancelled, PartiallyDelivered and partiallyShipped

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for effervescent-donut-4977b2 canceled.

Name Link
🔨 Latest commit 0f25344
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/65cc87174f9c790008a2f683

@michaelbromley
Copy link
Member

This makes me wonder: what about when someone defines custom states? Will that be a potential issue? Is it better to enumerate the known-good states rather than the known-bad states?

@martijnvdbrug
Copy link
Collaborator Author

@michaelbromley, yep, definitely. good point.

I guess that should make it

if (
 !AddingItems &&
 !ArrangingAdditionalPayment &&
 !ArrangingPayment &&
 !PaymentAuthorized
 ){
  return
}

@martijnvdbrug
Copy link
Collaborator Author

Updated :-)

@michaelbromley michaelbromley merged commit f02fc56 into vendure-ecommerce:master Feb 14, 2024
17 of 18 checks passed
@michaelbromley
Copy link
Member

Thanks!

@martijnvdbrug martijnvdbrug deleted the fix/mollie-order-states branch February 14, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants