feature(payments-plugin): PayPal two-step flow implementation #3099
Conversation
+ Added types for PayPal REST Api + Added GraphQL code for PayPal Payment provider + Added PayPal handler + Added PayPal service for REST requests + Added PayPal helper for order mutations and validations
* Switched to args based configuration instead of VendureConfig * Created new types for PayPalSdkPlugin to debug server * Some cleanup of not used imports
… native fetch api
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* Provided better error message in various cases * Better overview of mocked data using fixtures file * Integrating logger with logger ctx of the plugin
sonntag-philipp
changed the title
+ Added transactionId to refunds
.vscode/launch.json
Outdated
There was a problem hiding this comment.
I'm not quite sure if most of the maintainers use WebStorm, but this makes it way easier to execute a specific test file in VSCode.
Also had to make some changes to the get-package-dir to make it work not only for the e2e within the payments-plugin.
| }); | ||
|
|
||
| // eslint-disable-next-line no-console | ||
| console.log('Auth Token: ', shopClient.getAuthToken()); |
There was a problem hiding this comment.
This token is printed, so we can enter it in the Web UI of the paypal plugin. I would be open to setting this automatically in the Vendure REST Endpoint, but I wasn't quite sure how.
| } | ||
|
|
||
| // @ts-ignore | ||
| function html(strings, ...values) { |
There was a problem hiding this comment.
Well. I know we shouldn't integrate code only for syntax highlighting, but as this isn't code of the library itself and only exists for testing purposes, one could argue that it's still okay.
Especially as it doesn't require additional dependencies.
packages/payments-plugin/src/paypal/paypal-authorization.service.ts
Outdated
Show resolved
Hide resolved
packages/payments-plugin/src/paypal/paypal-authorization.service.ts
Outdated
Show resolved
Hide resolved
|
I still have to implement the idempotency headers supported by the PayPal Api, even though it already works without them. This could also be done is a future PR. |
+ Added unit tests for paypal order helper
- Removed unused method in helpers
sonntag-philipp
changed the title
| throw new Error('Please provide PayPal credentials in the .env file'); | ||
| } | ||
|
|
||
| const apiUrl = 'https://api-m.sandbox.paypal.com'; |
There was a problem hiding this comment.
I know its probably unlikely for paypal to change their sandbox URL but it could prove useful to get this URL also from the .env with the current value as default.
| if (!sessionOrder) { | ||
| throw new IllegalOperationError('Session has no active order'); | ||
| } | ||
| if (sessionOrder.state !== 'ArrangingPayment') { | ||
| throw new IllegalOperationError('Order must be in arranging payment state'); | ||
| } |
There was a problem hiding this comment.
I think these could be internationalized with existing error message for example there are:
"NO_ACTIVE_ORDER_ERROR": "There is no active Order associated with the current session",
and
"ORDER_MODIFICATION_ERROR": "Order contents may only be modified when in the \"AddingItems\" state",
"ORDER_PAYMENT_STATE_ERROR": "A Payment may only be added when Order is in \"ArrangingPayment\" state",
"ORDER_STATE_TRANSITION_ERROR": "Cannot transition Order from \"{ fromState }\" to \"{ toState }\"",
Might be good to take a second pass over all thrown errors and see what can be internationalized and reused.
Description
This PR introduces a PayPal payments plugin based on the PayPal Orders Api with a 2 step flow as specified in the Vendure documentation.
The main purpose of this plugin is to offer the user a solution where PayPal can be used directly without a step in between.
Documentation will be added by me before this plugin is merged. Just want to make sure I don't have to change it after review feedback of the implementation.
Breaking changes
I am not able to determine a breaking change. The implemented features represent new functionality and should have no effect on existing implementations.
Overview
Screenshots
Checklist
📌 Always:
👍 Most of the time: