-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(job-queue-plugin): Use multiple BullMQ queues instead of one #3108
base: minor
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There is currently one major problem in the core implementation: Every job needs to have a unique ID. But with BullMQ the IDs are only unique within the sequence of a queue. This is the core issue that still needs to be resolved. Edit: This has been solved by using a combination of the queue name and the BullMQ job ID as a unique ID |
@michaelbromley we are running into an issue, that it is not possible to display a list of all jobs from all queues in all states (aka the default list view). This is because of limitations of the BullMQ library and the way how the Redis keys are structured. I see two options here:
|
Description
Refactors the
bullmq-job-queue-strategy
to use a separate BullMQ queue for every Vendure job queue. This should improve the stability and issues with horizontally scaled worker instances. The current implementation pushes all jobs to a single BullMQ queue calledvendure-job-queue
, which is not best practice.Resolves #2419 and #1726
Breaking changes
There is no breaking change.
Checklist
📌 Always:
👍 Most of the time: