Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP status codes not recorded when not 200. #74

Closed
loudmouth opened this issue Oct 17, 2017 · 1 comment · Fixed by #80
Closed

HTTP status codes not recorded when not 200. #74

loudmouth opened this issue Oct 17, 2017 · 1 comment · Fixed by #80

Comments

@loudmouth
Copy link
Contributor

My type used for storing errors returned by my API hold the http status code so that user's can get more information while debugging their failed requests. However, when writing acceptance tests that the correct status codes are returned, DVR simply returns HTTP status code 0 always.

It looks like the status code is not being recorded in the cassette.

Any chance we can also record the status code?
@loudmouth loudmouth changed the title HTTP status codes not recorded HTTP status codes not recorded when not 200. Oct 17, 2017
sethhoward pushed a commit to sethhoward/DVR that referenced this issue Oct 31, 2017
Fixes HTTP status codes not recorded when not 200. venmo#74
e0eb3af
This was referenced Oct 31, 2017
Merged
Closed
dmiluski added a commit that referenced this issue Feb 14, 2018
@dmiluski
Merge pull request #75 from sethhoward/hotfix/status-codes-not-record…
242d694 
…ed-74

Fixes HTTP status codes not recorded when not 200. #74
@loudmouth
Copy link
Contributor Author

It appears status codes are not recorded at all anymore.

Also, HTTP headers are now absent for HTTP errors (previously they were present)

This was referenced Jun 12, 2018
Merged
Closed
olegdanu-newstore pushed a commit to NewStore/DVR that referenced this issue Sep 27, 2018
@olegdanu-newstore
Fixes HTTP status codes not recorded when not 200. venmo#74
94dae7d
olegdanu-newstore pushed a commit to NewStore/DVR that referenced this issue Sep 28, 2018
@olegdanu-newstore
Fixes HTTP status codes not recorded when not 200. venmo#74
dc54815
olegdanu-newstore pushed a commit to NewStore/DVR that referenced this issue Sep 28, 2018
@olegdanu-newstore
Fixes HTTP status codes not recorded when not 200. venmo#74
cbe1483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Debug status code not being recorded loudmouth/DVR
1 participant
@loudmouth