Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix docker images name" #654

Closed

Conversation

egrimley-arm
Copy link
Contributor

@egrimley-arm egrimley-arm commented Aug 15, 2023

This reverts commit f5af805.

This is a PR on main corresponding to #653 on veracruz-v2.

@egrimley-arm egrimley-arm self-assigned this Aug 15, 2023
@mathias-arm
Copy link
Contributor

Simply reverting does not address the issues from #650. I think docker/README.md also needs to be updated, because some issues stem from the difference between make linux-base and make linux-build (replace linux with nitro, ci or localci).

@egrimley-arm
Copy link
Contributor Author

There seem to be a lot of things wrong in docker/README.md (I don't think "squash" is an experimental feature any more, there is no submodule, ...), but I can't see any that relate to this PR in particular. I'll probably make a separate PR tomorrow, or two PRs as those things should probably be fixed on veracruz-v2.

@mathias-arm
Copy link
Contributor

Closing in favor of #656 which contains this change and I think is the best solution.

@egrimley-arm egrimley-arm deleted the pr-image-names branch August 21, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants