Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: go fmt #201

Merged
merged 1 commit into from
Sep 13, 2024
Merged

chore: go fmt #201

merged 1 commit into from
Sep 13, 2024

Conversation

alex-richards
Copy link
Contributor

Reformatted with go fmt. bench_test.go was CRLF formatted.

Signed-off-by: Alex Richards <alex-richards@users.noreply.github.com>
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (2b6f94f) to head (fae8721).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   92.04%   92.47%   +0.43%     
==========================================
  Files          12       12              
  Lines        1973     1622     -351     
==========================================
- Hits         1816     1500     -316     
+ Misses        108       66      -42     
- Partials       49       56       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveLasker SteveLasker added this to the v1.4.0 milestone Aug 16, 2024
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveLasker
Copy link
Contributor

This has been tagged for the next v1.4.0 release. If folks feel this should be in v1.3], please indicate it here.

@OR13
Copy link
Contributor

OR13 commented Sep 13, 2024

I would object to putting this in 1.3, leave it in 1.4

@SteveLasker
Copy link
Contributor

Merging, with the intent to release in 1.4 as 1.3 is ready for release.

@SteveLasker SteveLasker merged commit 741bc28 into veraison:main Sep 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants