Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address routing issues with invalid dest #102

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Address routing issues with invalid dest #102

merged 4 commits into from
Jun 5, 2023

Conversation

dglsparsons
Copy link
Collaborator

Needs a thorough test:

  • The dest field for routes was missing a leading /.
  • This caused issues where routes were incorrectly omitting the /, leading to the Rust Router not finding a match.
  • path still omits the /, and points directly to the source file. This is used to determine which function to call / what the function is named.

@dglsparsons dglsparsons requested a review from ecklf June 2, 2023 15:18
@ecklf ecklf merged commit 9f3dd6d into main Jun 5, 2023
@ecklf ecklf deleted the fix-dest branch June 5, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants