Refactor tests to use vercel dev #38
Conversation
There was a problem hiding this comment.
@de-luca Thanks for this, and sorry for the delay. One comment, and could you rebase this with the latest master? Thanks!
| @@ -0,0 +1,9 @@ | |||
| [package] | |||
There was a problem hiding this comment.
This file can probably be deleted, no? Or is there a reason a file with a .backup extension is included?
There was a problem hiding this comment.
Good catch it was leftover from my tests.
de-luca
force-pushed
the
tests
branch
2 times, most recently
from
5cacf43
to
81c04db
Compare
|
I rebased the branch and cleaned the leftover (I hope I didn't took too long). |
|
Hi @de-luca, no worries at all! I've been busy as well. It looks like there's one last remaining conflict in the |
|
Thanks for this @de-luca and for your patience 😄 |
Hi!
As evoked in #31, the tests seamed outdated.
I refactored them into using
vercel dev.This mainly remove the publication requirement.
However it seems like
vercel devcannot be used without linking to a project (see vercel/vercel#4925).I kept what was beeing tested and only changed the way around.
This can also run on GitHub Actions, although it would require a vercel token.
(This can be seen here: https://github.com/de-luca/now-rust/actions?query=branch%3Agh)