Execute cargo build inside workPath
#85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’ll give it some testing next week and see if it causes any issues. Thank you! Are you interested in testing an experimental feature for merged handlers in one function in your project? |
|
Oh hell yes, would be great to test out any beta stuff you got! |
|
@oscartbeaumont @Brendonovich awesome. Mind to share your thoughts on #86? I've also joined your Discord (@ecklf). |
ecklf
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In attempting to get the rspc workspace deployed on Vercel, we found that the execution of
cargo buildwas not respecting the Root Directory that was configured for the project, but instead the root of the repository. Changing the working directory of that command toworkPathseemed to solve the issue.I wouldn't be surprised if this is a naive fix and other things need to be changed, but it worked for us!