Fix gradient generation to reduce hue collisions for longer usernames #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
styfle
reviewed
Sep 30, 2024
styfle
reviewed
Sep 30, 2024
There was a problem hiding this comment.
This still seems to suffer from the same bug. Notice these are all the same image:
https://avatar-git-fork-antoinekm-antoinekm-fix-collisions.vercel.sh/styfle1
https://avatar-git-fork-antoinekm-antoinekm-fix-collisions.vercel.sh/styfle2
https://avatar-git-fork-antoinekm-antoinekm-fix-collisions.vercel.sh/styfle3
Merged
|
This should fix it: #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tobiaslins,
What did I change?
generateGradientfunction by introducing a secondary hash function to reduce hue collisions for longer usernames.Why did I change it?
djb2hash function. This update enhances the uniqueness of gradients, ensuring better differentiation for longer strings without changing lightness or saturation.Linked Issues
Close: #52