Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New header UI #1067

Merged
merged 7 commits into from
Jul 11, 2023
Merged

New header UI #1067

merged 7 commits into from
Jul 11, 2023

Conversation

StephDietz
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jul 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
commerce-shopify ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2023 6:55pm

@StephDietz StephDietz changed the base branch from main to design-refresh July 10, 2023 20:57
manovotny
manovotny requested changes Jul 11, 2023
View reviewed changes
components/layout/navbar/index.tsx Outdated Show resolved Hide resolved
components/layout/navbar/index.tsx Outdated Show resolved Hide resolved
components/layout/navbar/search.tsx Outdated Show resolved Hide resolved
components/layout/navbar/search.tsx Outdated Show resolved Hide resolved
@manovotny manovotny mentioned this pull request Jul 11, 2023
Merged
manovotny
manovotny requested changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@manovotny manovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a couple of break points that produce awkward site name shifts / stacking.

We probably just need to either:

  1. Go to the mobile header much sooner.
  2. Move search over next to the cart.

CleanShot 2023-07-11 at 13 20 39@2x

CleanShot 2023-07-11 at 13 20 52@2x

@evilrabbit
Copy link
Member

I would go to mobile sooner or we can hide ACME STORE and keep the icon on smaller screens.

@manovotny manovotny merged commit 7bad989 into design-refresh Jul 11, 2023
2 checks passed
@manovotny manovotny deleted the DX-1730 branch July 11, 2023 19:04
StephDietz added a commit that referenced this pull request Jul 11, 2023
@StephDietz
New header UI (#1067)
050134b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotny manovotny manovotny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StephDietz @evilrabbit @manovotny