-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendure custom checkout support #619 #714
Conversation
@hangai247 is attempting to deploy a commit to the Vercel Solutions Team on Vercel. A member of the Team first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). commerce-local – ./site🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-local/7doV2szZceyEuorQRaHSasVSkhrW |
Hey @michaelbromley Is there an ETA for this feature to be merged? cc: @hangai247 |
@briandiaz I don't know, I'm not a maintainer of this repo so I cannot decide that unfortunately 😢 |
@hangai247 Could you please add a Description to the PR to understand all you're adding please? We can review it and merge it. |
@michaelbromley Does this have your approval from the Vendure perspective? All approved practices? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@okbel I'm just pulling this PR in locally to try it out. Unfortunately just had to spend ages trying to resolve #674 (in the end I used the suggested fix at #681 (comment) to get it working). Will update this PR with my feedback. |
Oh that was quick. |
@okbel ok I ended up having to make a bunch of fixes. @hangai247's work on this PR is excellent, so it was mainly just polishing up a few things and handling some cases in the checkout flow that weren't already covered. This is in a new PR at #760. |
Hey! Following up here. Is this something you're still interested in seeing through? |
No description provided.