Ensure we cancel consumeUint8ArrayReadableStream if iteration breaks
#428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6ffc30e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jridgewell
force-pushed
the
jrl-cancel-stream
branch
from
5e94b45 to
1ef675e
Compare
jridgewell
force-pushed
the
jrl-cancel-stream
branch
from
1ef675e to
ec5b63a
Compare
Kikobeats
force-pushed
the
jrl-cancel-stream
branch
from
ec5b63a to
ea0e511
Compare
Kikobeats
approved these changes
Jun 26, 2023
Merged
|
@jridgewell: the amount of real-world dollars that this change will save (not transfer to OpenAI but keep in the dev's pockets) cannot be overstated :) |
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Jun 29, 2023
### What? The updates `edge-runtime` to the latest version ### Why? vercel/edge-runtime#428 fixes `consumeUint8ArrayReadableStream` so that when we break iteration early (due to client disconnect), we cleanup the inner stream. That will fire the stream's `cancel` handler, and allow devs to disconnect from an AI service fetch. ### How? `edge-runtime` maintain a `try {} finally {}` over the inner stream's iteration. When we early break, JS will call `it.return()`, and that will resume `consumeUint8ArrayReadableStream` with an abrupt completion (essentially, the `yield` turns into a `return`). We'll be able to trigger the `finally {}` block with that, and we call `inner.cancel()` to cleanup. Fixes vercel/ai#90
enricoros
added a commit
to enricoros/big-AGI
that referenced
this pull request
Jul 5, 2023
Thanks to the Vercel team (@jridgewell), an interruption of the stream on the client side will lead to the cancellation of the TransformStream on the servers side, which in turns cancels the open fetch() to the upstream. This was a long needed change and we are happy to report it works well. Related: #114 - vercel/ai#90 - vercel/edge-runtime#428 - trpc/trpc#4586 (enormous thanks to the tRPC team to issue a quick release as well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now,
consumeUint8ArrayReadableStreamnever explicitly closes the the readable stream we're consuming from. Unfortunately that means that devs aren't able to release their resources, leaking them until the GC eventually runs.This is important for the AI streaming use case, so that devs can detect that a client has disconnected the stream and in turn disconnect the fetch they're maintaining to the AI service.