-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature-flag-firebase-remote-config #670
Open
tengweiherr
wants to merge
10
commits into
vercel:main
Choose a base branch
from
tengweiherr:feat/feature-flag-firebase-remote-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feature-flag-firebase-remote-config #670
tengweiherr
wants to merge
10
commits into
vercel:main
from
tengweiherr:feat/feature-flag-firebase-remote-config
+4,269
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengweiherr
requested review from
okbel,
lfades,
goncy,
dominiksipowicz,
leerob,
steven-tey and
lpalmes
as code owners
May 2, 2023 02:19
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@tengweiherr is attempting to deploy a commit to the Vercel Examples Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature flag with Firebase remote config, inspired by the example
feature-flag-split
index.tsx
,B.tsx
,C.tsx
) in about folder./about
,/about/B
,/about/C
).about
page, instead of calling API routes and sending HTTP requests to fetch data from Firebase, the middleware can directly retrieve the data from the pre-generated JSON file and assign a variant to it.Full article about this approach here.
Demo URL
https://feature-flag-firebase-remote-config.vercel.app
Type of Change
New Example Checklist
npm run new-example
was used to create the example