Expose ‘true colour’ support in $COLORTERM #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Further discussion here: <https://gist.github.com/XVilka/8346728#detection>
|
+1 from me. Thanks @ELLIOTTCABLE, good to see you here! |
chabou
approved these changes
Nov 22, 2017
|
Thank you so much for your help 🙏 |
|
I reverted my merge, because It should have been merged in I will duplicate this PR and target canary |
|
My bad! I didn't even realize there was a separate branch. 🤣 Here's hoping I can contribute more awesome stuff! <3 |
|
@chabou the canary branch doesn't support truecolor though? xtermjs/xterm.js#484 |
|
@Tyriar I totally forgot that. Thank you for your insight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further discussion here: https://gist.github.com/XVilka/8346728#detection
This environment variable seems to be becoming standardized-upon. That said, although a single-line change, it is increasing the bloat dumped onto the environment by 25%, so feel free to discuss/wait/reject!
<3