Add support for tsconfig paths. (fixes #150)
#151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
+ Coverage 76.82% 77.49% +0.66%
==========================================
Files 11 11
Lines 492 511 +19
==========================================
+ Hits 378 396 +18
- Misses 114 115 +1
Continue to review full report at Codecov.
|
|
@odensc I really cannot accept this without tests. Any chance you can add a few? Thank you! |
|
@rauchg Sure, was gonna add tests but couldn't figure out how to put TypeScript tests in with the current structure. |
|
I believe we already have a typescript test in there! |
guybedford
added a commit
that referenced
this pull request
Dec 17, 2018
rauchg
added a commit
that referenced
this pull request
Dec 17, 2018
* Revert "fix minify default (#168)" This reverts commit c289b28. * Revert "Reduce asset emission and handle unexpected core assets (#166)" This reverts commit b83e921. * Revert "use graceful-fs (#167)" This reverts commit 4ab1f82. * Revert "fix ignore" This reverts commit e6ab392. * Revert "add typescript config for test" This reverts commit fa95d0b. * Revert "0.6.0" This reverts commit 2f12e50. * Revert "add typescript test" This reverts commit d4d0ead. * Revert "Add support for tsconfig `paths`. (fixes #150) (#151)" This reverts commit 4c227fb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
pathsoption in tsconfig, usingtsconfig-paths-webpack-plugin.