Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues described in #142, which turned out to be:
Could not locate the bindings file.
0.21.1 issue, which was due to the bindings search happening from the id looking inpkg/lib/build
of the path doing the require instead of the basepkg/build
. Updated to use the package base path in thecreateBindings
static implementation shim function.The shared library path missing error -
Error: dlopen(/Users/jrdn/sharp-example/dist/sharp.node, 1): Library not loaded: @rpath/libvips-cpp.dylib
. The problem here is that therpath
is hard-coded into the binary, so we need to ensure that where the binary is emitted and where the shared libraries are emitted ends up being the same relative path. This is done by emitting binaries based on the package path so we outputbuild/Releases/binary.node
instead of justbinary.node
in the output folder, and then similarly for the dynamic library emission we ensure the same folder structure.