Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate minify compress option #161

Merged
merged 2 commits into from
Dec 16, 2018
Merged

Separate minify compress option #161

merged 2 commits into from
Dec 16, 2018

Conversation

guybedford
Copy link
Contributor

This adds a separate compress / --compress CLI and API option, that need to be explicitly opted into for terser compression.

The size of the ncc build itself is exactly the same with and without Terser compression, yet takes 27s with compression, vs 25.7 without compression.

@guybedford
Copy link
Contributor Author

Given the lack of any effect of terser compression, it could even be worth disabling it completely and not even having a flag here.

I've added another commit that does that, which can be reverted if this is really needed, but I don't see a good reason to include it personally since it seems Webpack is already doing the most basic optimizations for us anyway.

@guybedford
Copy link
Contributor Author

guybedford commented Dec 16, 2018

(When I mean that the build size is exactly the same, I really do mean it is identically 5,150,515 bytes between the two)

Correction: verified this again and got 5,150,480 bytes for the compressed build.

@codecov-io
Copy link

Codecov Report

Merging #161 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #161   +/-   ##
======================================
  Coverage    72.3%   72.3%           
======================================
  Files          10      10           
  Lines         473     473           
======================================
  Hits          342     342           
  Misses        131     131
Impacted Files Coverage Δ
src/index.js 93.15% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7bc7a0...9a11a4e. Read the comment docs.

@rauchg rauchg merged commit 2102cf5 into master Dec 16, 2018
@rauchg rauchg deleted the separate-compress branch December 16, 2018 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants